[Doc] Tiny fix for regression tests example

From: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "pgsql-docs(at)lists(dot)postgresql(dot)org" <pgsql-docs(at)lists(dot)postgresql(dot)org>, "peter(at)eisentraut(dot)org" <peter(at)eisentraut(dot)org>, Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
Subject: [Doc] Tiny fix for regression tests example
Date: 2021-07-23 06:12:02
Message-ID: OS0PR01MB6113954B883ACEB2DDC973F2FBE59@OS0PR01MB6113.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

Hi

When reading PG DOC, found some example code not correct as it said.

https://www.postgresql.org/docs/devel/regress-run.html

Here's a tiny fix in regress.sgml.

-make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB"

+make check PGOPTIONS="-c geqo=off -c work_mem=50MB"

log_checkpoints couldn't be set in PGOPTIONS.

Replace log_checkpoints with geqo in the example code.

-make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf"

+make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf"

User needs to specify $(pwd) to let the command execute as expected.

The above example code is added by Peter in PG14. So I think we need to apply this fix at PG14/master.

I proposed this fix at pgsql-docs(at)lists(dot)postgresql(dot)org<mailto:pgsql-docs(at)lists(dot)postgresql(dot)org> at [1]. But no reply except Craig. So I please allow me to post the patch at Hackers’ mail list again in case the fix is missed.

[1] https://www.postgresql.org/message-id/OS0PR01MB6113FA937648B8F7A372359BFB009%40OS0PR01MB6113.jpnprd01.prod.outlook.com

Regards,

Tang

Attachment Content-Type Size
0001-minor-fix-for-regress-example.patch application/octet-stream 1.1 KB

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2021-07-23 13:02:44 /usr/local/pgsql Location on Manjaro/Arch
Previous Message Alvaro Herrera 2021-07-22 22:14:58 Re: Link t the souce code

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2021-07-23 07:41:05 Re: psql - add SHOW_ALL_RESULTS option
Previous Message Greg Nancarrow 2021-07-23 06:00:14 Re: Parallel scan with SubTransGetTopmostTransaction assert coredump