| From: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | "smithpb2250(at)gmail(dot)com" <smithpb2250(at)gmail(dot)com>, "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "david(dot)zhang(at)highgo(dot)ca" <david(dot)zhang(at)highgo(dot)ca>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Support tab completion for upper character inputs in psql |
| Date: | 2021-06-23 12:43:53 |
| Message-ID: | OS0PR01MB61136721363BD08576725F22FB089@OS0PR01MB6113.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
I've updated the patch to V8 since Tom, Kyotaro and Laurenz discussed the lower case issue of German/Turkish language at [1].
Differences from V7 are:
* Add a function valid_input_text which checks the input text to see if it only contains alphabet letters, numbers etc.
* Delete the flag setting of "completion_case_sensitive=false" which introduced in V1 patch and no use now.
As you can see, now the patch limited the lower case transform of the input to alphabet letters.
By doing that, language like German/Turkish will not affected by this patch.
Any comment or suggestion on this patch is very welcome.
[1]
https://www.postgresql.org/message-id/1282887.1619151455%40sss.pgh.pa.us
https://www.postgresql.org/message-id/20210423.144443.2058612313278551429.horikyota.ntt%40gmail.com
https://www.postgresql.org/message-id/a75a6574c0e3d4773ba20a73d493c2c9983c0657.camel%40cybertec.at
Regards,
Tang
| Attachment | Content-Type | Size |
|---|---|---|
| V8-0001-Support-tab-completion-with-a-query-result-for-upper.patch | application/octet-stream | 7.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2021-06-23 12:50:07 | Re: PG 14 release notes, first draft |
| Previous Message | Andrew Dunstan | 2021-06-23 12:11:43 | Re: intermittent failures in Cygwin from select_parallel tests |