RE: Remove "FROM" in "DELETE FROM" when using tab-completion

From: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: Remove "FROM" in "DELETE FROM" when using tab-completion
Date: 2021-05-10 12:26:55
Message-ID: OS0PR01MB61130BE81FA60AF689309B8FFB549@OS0PR01MB6113.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Monday, May 10, 2021 4:15 PM, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote
>We should change all to DELETE FROM (apart from \help of course), and same for
>INSERT, change to INSERT INTO everywhere it makes sense.

Thanks for the reply. Your advice sounds reasonable to me.
So I tried to change all "DELETE" to "DELETE FROM" and "INSERT" to "INSERT INTO" in the attached patch except
the follow cases which I think is in accordance with what PG-Doc said.
CREATE POLICY
CREATE [ OR REPLACE ] RULE
CREATE [ OR REPLACE ] TRIGGER
ALTER DEFAULT PRIVILEGES

After applying the patch, the tap-tests for psql is passed.
Please be free to tell me anything insufficient you found in my fix. Thanks.

Regards,
Tang

Attachment Content-Type Size
0001-TAB-completion-modification-for-INSERT-INTO-and-DELE.patch application/octet-stream 3.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2021-05-10 12:29:40 Re: Why do we have perl and sed versions of Gen_dummy_probes?
Previous Message Amit Langote 2021-05-10 12:20:52 Re: Inherited UPDATE/DELETE vs async execution