RE: Hash index build performance tweak from sorting

On Monday, May 30, 2022 4:13 PMshiy(dot)fnst(at)fujitsu(dot)com <shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tue, May 10, 2022 5:43 PM Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>
> wrote:
> >
> > On Sat, 30 Apr 2022 at 12:12, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> > wrote:
> > >
> > > Few comments on the patch:
> > > 1. I think it is better to use DatumGetUInt32 to fetch the hash key
> > > as the nearby code is using.
> > > 2. You may want to change the below comment in HSpool
> > > /*
> > > * We sort the hash keys based on the buckets they belong to. Below
> > masks
> > > * are used in _hash_hashkey2bucket to determine the bucket of given
> > hash
> > > * key.
> > > */
> >
> > Addressed in new patch, v2.
> >
>
> I think your changes looks reasonable.

+1, the changes look good to me as well.

Best regards,
Hou zj