| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | RE: Synchronizing slots from primary to standby |
| Date: | 2024-01-25 02:57:30 |
| Message-ID: | OS0PR01MB5716E304C26E6ACE0BE84925947A2@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, January 24, 2024 6:31 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Jan 23, 2024 at 5:13 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> >
> > Thanks Ajin for testing the patch. PFA v66 which fixes this issue.
> >
>
> I think we should try to commit the patch as all of the design concerns are
> resolved now. To achieve that, can we split the failover setting patch into the
> following: (a) setting failover property via SQL commands and display it in
> pg_replication_slots (b) replication protocol command (c) failover property via
> subscription commands?
>
> It will make each patch smaller and it would be easier to detect any problem in
> the same after commit.
Agreed. I split the original 0001 patch into 3 patches as suggested.
Here is the V68 patch set.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v68-0005-Slot-sync-worker-as-a-special-process.patch | application/octet-stream | 38.3 KB |
| v68-0006-Allow-logical-walsenders-to-wait-for-the-physica.patch | application/octet-stream | 40.7 KB |
| v68-0007-Non-replication-connection-and-app_name-change.patch | application/octet-stream | 9.7 KB |
| v68-0008-Document-the-steps-to-check-if-the-standby-is-re.patch | application/octet-stream | 6.6 KB |
| v68-0001-Add-the-failover-property-to-replication-slot.patch | application/octet-stream | 20.4 KB |
| v68-0002-Allow-setting-failover-property-in-the-replicati.patch | application/octet-stream | 19.7 KB |
| v68-0003-Add-a-failover-option-to-subscriptions.patch | application/octet-stream | 63.7 KB |
| v68-0004-Add-logical-slot-sync-capability-to-the-physical.patch | application/octet-stream | 88.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-01-25 03:17:55 | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Previous Message | jian he | 2024-01-25 02:53:58 | Re: Make COPY format extendable: Extract COPY TO format implementations |