From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger |
Date: | 2022-07-26 13:00:41 |
Message-ID: | OS0PR01MB5716DEAF92CB2DF114C0E68694949@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Monday, July 25, 2022 6:26 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Jul 25, 2022 at 09:25:07AM +0000, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> > BTW, while reviewing it, I found there are some more subcommands that
> > the
> > get_altertable_subcmdtypes() doesn't handle(e.g., ADD/DROP/SET
> > IDENTITY and re ADD STAT). Shall we fix them all while on it ?
> >
> > Attach a minor patch to fix those which is based on the v2 patch set.
>
> @@ -300,6 +300,18 @@ get_altertable_subcmdinfo(PG_FUNCTION_ARGS)
> [ ... ]
> default:
> strtype = "unrecognized";
> break;
>
> Removing the "default" clause would help here as we would get compiler
> warnings if there is anything missing. One way to do things is to set strtype to
> NULL before going through the switch and have a failsafe as some commands
> are internal so they may not be worth adding to the output.
Thanks for the suggestion. I have removed the default and found some missed
subcommands in 0003 patch. Attach the new version patch here
(The 0001 and 0002 is unchanged).
Best regards,
Hou zj
Attachment | Content-Type | Size |
---|---|---|
v3-0003-Add-support-for-some-missed-commands-in-test_ddl_.patch | application/octet-stream | 7.2 KB |
v3-0001-Collect-ObjectAddress-for-ATTACH-DETACH-PARTITION.patch | application/octet-stream | 2.0 KB |
v3-0002-Extend-test_ddl_deparse-for-ALTER-TABLE-.-ATTACH-.patch | application/octet-stream | 10.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2022-07-26 13:08:58 | Re: Restructure ALTER TABLE notes to clarify table rewrites and verification scans |
Previous Message | Pierre | 2022-07-26 12:41:55 | Re: log_line_prefix: make it possible to add the search_path |