| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: row filtering for logical replication |
| Date: | 2022-01-26 03:07:51 |
| Message-ID: | OS0PR01MB5716D0BE62E37A033A78A4EB94209@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, January 26, 2022 9:43 AM I wrote:
> On Tuesday, January 25, 2022 1:55 PM Peter Smith <smithpb2250(at)gmail(dot)com>
> wrote:
>
> Changed.
>
> Attach the V71 patch set which addressed the above comments.
> The patch also includes the changes:
> - Changed the function RelationBuildPublicationDesc's signature to be void
> and
> pass the PublicationDesc* from stack instead of palloc-ing it. [1]
> - Removed the Push/Pop ActiveSnapshot related code. IIRC, these functions
> are
> needed when we execute functions which will execute SQL(via SPI functions)
> to
> access the database. I think we don't need the ActiveSnapshot for now as we
> only support built-in immutable in the row filter which should only use the
> argument values passed to the function.
> - Adjusted some comments in pgoutput.c.
There was a miss in the posted patch which didn't initialize the parameter in
RelationBuildPublicationDesc, sorry for that. Attach the correct patch this time.
Best regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v71-0001-Allow-specifying-row-filters-for-logical-replication.patch | application/octet-stream | 155.9 KB |
| v71-0002-Row-filter-tab-auto-complete-and-pgdump.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-01-26 03:12:27 | BRIN summarization vs. WAL logging |
| Previous Message | houzj.fnst@fujitsu.com | 2022-01-26 03:07:18 | RE: row filtering for logical replication |