| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | RE: Conflict detection and logging in logical replication |
| Date: | 2024-08-28 04:14:11 |
| Message-ID: | OS0PR01MB5716CC65E4AD48F2368FE51894952@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, August 28, 2024 12:11 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> > > > Peter Smith mentioned to me off-list that the names of conflict
> > > > types 'update_differ' and 'delete_differ' are not intuitive as
> > > > compared to all other conflict types like insert_exists,
> > > > update_missing, etc. The other alternative that comes to mind for
> > > > those conflicts is to name them as
> > 'update_origin_differ'/''delete_origin_differ'.
> > > >
> > >
> > > For things to "differ" there must be more than one them. The plural
> > > of origin is origins.
> > >
> > > e.g. 'update_origins_differ'/''delete_origins_differ'.
> > >
> > > OTOH, you could say "differs" instead of differ:
> > >
> > > e.g. 'update_origin_differs'/''delete_origin_differs'.
> > >
> >
> > +1 on 'update_origin_differs' instead of 'update_origins_differ' as
> > the former is somewhat similar to other conflict names 'insert_exists'
> > and 'update_exists'.
>
> Since we reached a consensus on this, I am attaching a small patch to rename
> as suggested.
Sorry, I attached the wrong patch. Here is correct one.
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-the-conflict-types-for-origin-differ-cases.patch | application/octet-stream | 9.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2024-08-28 04:27:07 | Re: Conflict Detection and Resolution |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-08-28 04:11:07 | RE: Conflict detection and logging in logical replication |