| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |
| Date: | 2024-11-19 09:09:37 |
| Message-ID: | OS0PR01MB5716C8F120D53A0FF645FAB294202@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, November 19, 2024 3:15 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> I noticed that we can add 'publish_generated_columns = true' for the case of
> generated column. So we won't need to remove the test. I have made the
> changes in v9 patch [1].
I think this would unexpectedly change the original purpose of that testcase,
which is to test the bug mentioned in commit b797def.
Basically, I expected the new testcase to fail if we remove the codes fix added in
b797def, but the new testcase can pass even after that.
If we confirmed that that bug will never be triggered after applying the fix in
the thread, it would be better Tt remove that testcase and mention it in the
commit message.
>
> [1]:
> https://www.postgresql.org/message-id/CANhcyEVCqrSYxAg_s99VYevUc4F
> -Lb9XowWUC2E5RG0i8RtZwA%40mail.gmail.com
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhijie Hou (Fujitsu) | 2024-11-19 09:12:29 | RE: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |
| Previous Message | jian he | 2024-11-19 09:07:45 | tab_complete for copy(merge |