| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>, Alexey Lesovsky <lesovsky(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Subject: | RE: Skipping logical replication transactions on subscriber side |
| Date: | 2021-10-27 03:28:09 |
| Message-ID: | OS0PR01MB5716AFFD9256A76EA190907594859@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thurs, Oct 21, 2021 12:59 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I've attached updated patches. In this version, in addition to the review
> comments I go so far, I've changed the view name from
> pg_stat_subscription_errors to pg_stat_subscription_workers as per the
> discussion on including xact info to the view on another thread[1].
> I’ve also changed related codes accordingly.
When reviewing the v18-0002 patch.
I noticed that "RESET SYNCHRONOUS_COMMIT" does not take effect
(RESET doesn't change the value to 'off').
+ if (!is_reset)
+ {
+ opts->synchronous_commit = defGetString(defel);
- ...
+ }
I think we need to add else branch here to set the synchronous_commit to 'off'.
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-10-27 03:34:57 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Masahiko Sawada | 2021-10-27 03:02:22 | Re: Skipping logical replication transactions on subscriber side |