RE: Parallel INSERT SELECT take 2

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: RE: Parallel INSERT SELECT take 2
Date: 2021-05-14 08:24:30
Message-ID: OS0PR01MB5716A5C5FDB8F0A44791B41194509@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> Currently the 1st patch actually also contains the changes for the
> Parallel-SELECT-for-INSERT functionality. This is not obvious.
> So I think this should be split out into a separate patch (i.e. the minor planner
> update and related planner comment changes,
> is_parallel_allowed_for_modify() function, max_parallel_hazard() update, XID
> changes).
> Also, the regression tests' "serial_schedule" file has been removed since you
> posted the v3-POC patches, so you need to remove updates for that from your
> 3rd patch.

Thanks for the comments, I have posted new version patches with this change.

> How about reorganisation of the patches like the following?
> 0001: CREATE ALTER TABLE PARALLEL DML
> 0002: parallel-SELECT-for-INSERT (planner changes,
> max_parallel_hazard() update, XID changes)
> 0003: pg_get_parallel_safety()
> 0004: regression test updates

Thanks, it looks good and I reorganized the latest patchset in this way.

Attaching new version patches with the following change.

0003
Change functions arg type to regclass.

0004
remove updates for "serial_schedule".

Best regards,
houzj

Attachment Content-Type Size
v4-POC-0004-regression-test-updates.patch application/octet-stream 32.6 KB
v4-POC-0001-CREATE-ALTER-TABLE-PARALLEL-DML.patch application/octet-stream 37.6 KB
v4-POC-0002-parallel-SELECT-for-INSERT.patch application/octet-stream 9.9 KB
v4-POC-0003-get-parallel-safety-functions.patch application/octet-stream 28.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2021-05-14 08:24:43 RE: Parallel INSERT SELECT take 2
Previous Message Pavel Borisov 2021-05-14 08:21:28 Re: OOM in spgist insert