| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com> |
| Subject: | RE: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
| Date: | 2021-08-24 01:01:51 |
| Message-ID: | OS0PR01MB5716A4EF1775012E42D57B4B94C59@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> -----Original Message-----
> From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
> Sent: Tuesday, August 24, 2021 8:52 AM
>
> Thanks. The patch for HEAD looks good to me. Regarding the patch for PG14, I
> think we need to update the comment as well:
>
> @@ -987,7 +986,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, bool
> isTopLevel)
> PreventInTransactionBlock(isTopLevel, "ALTER SUBSCRIPTION with
> refresh");
>
> /* Only refresh the added/dropped list of publications. */
> - sub->publications = stmt->publication;
> + sub->publications = publist;
>
Thanks for the comment, attach new version patch which fixed it.
Best regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-PG15-Fix-Alter-Subscription-Add-Drop-Publication-refre.patch | application/octet-stream | 10.3 KB |
| v8-0001-PG14-Fix-Alter-Subscription-Add-Drop-Publication-refre_patch | application/octet-stream | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-08-24 01:42:26 | Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
| Previous Message | Masahiko Sawada | 2021-08-24 00:51:43 | Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |