| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Added schema level support for publication. |
| Date: | 2021-09-22 02:32:07 |
| Message-ID: | OS0PR01MB5716A257F9EA3A3B35180C1094A29@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, September 22, 2021 2:02 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> Attached v30 patch has the fixes for the same.
Thanks for updating the patches.
I have one comment.
@@ -474,7 +707,75 @@ AlterPublication(ParseState *pstate, AlterPublicationStmt *stmt)
...
+ if (list_length(relations))
+ {
...
+ /* remove the existing schemas from the publication */
+ PublicationDropSchemas(pubform->oid, delschemas, false);
...
+ }
After more thoughts on it, I still don't think drop all the schemas under " if
(list_length(relations))" is a good idea. I think 1) we'd better keep schema
and relation code separate. 2) if we support other type object(SEQUENCE) I the
future and only SET xx SEQUENCE, I think the above logic won't work because
both relations and schemaidlist will be NIL.
Same as the logic of drop all tables under " if (list_length(schemaidlist))".
Thoughs ?
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-09-22 03:21:38 | Re: Added schema level support for publication. |
| Previous Message | Peter Geoghegan | 2021-09-22 02:02:03 | Re: Unintended interaction between bottom-up deletion and deduplication's single value strategy |