| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Shubham Khanna' <khannashubham1197(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Pgoutput not capturing the generated columns |
| Date: | 2024-10-28 11:45:41 |
| Message-ID: | OS0PR01MB571691604527472B06B844AC944A2@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, October 28, 2024 2:54 PM Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
>
> 02. 031_column_list.pl
>
> ```
> -# TEST: Generated and dropped columns are not considered for the column
> list.
> +# TEST: Dropped columns are not considered for the column list.
> # So, the publication having a column list except for those columns and a #
> publication without any column (aka all columns as part of the columns #
> list) are considered to have the same column list.
> ```
>
> Based on the comment, this case does not test the behavior of generated
> columns anymore. So, I felt column 'd' could be removed from the case.
I think keeping the generated column can test the cases you mentioned
in comment #03, so we can modify the comments here to make that clear.
>
> 03. 031_column_list.pl
>
> Can we test that generated columns won't be replaced if it does not included in
> the column list?
As stated above, it can be covered in existing tests.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-10-28 12:07:16 | Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-10-28 11:43:02 | RE: Pgoutput not capturing the generated columns |