RE: Collect statistics about conflicts in logical replication

On Tuesday, September 3, 2024 7:23 PM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tuesday, September 3, 2024 7:12 PM Amit Kapila
> <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Fri, Aug 30, 2024 at 12:15 PM Zhijie Hou (Fujitsu)
> > <houzj(dot)fnst(at)fujitsu(dot)com>
> > wrote:
> > >
> > > Here is V5 patch which addressed above and Shveta's[1] comments.
> > >
> >
> > Testing the stats for all types of conflicts is not required for this
> > patch especially because they increase the timings by 3-4s. We can add
> > tests for one or two types of conflicts.
> >
> > *
> > (see
> > + * PgStat_StatSubEntry::conflict_count and
> > + PgStat_StatSubEntry::conflict_count)
> >
> > There is a typo in the above comment.
>
> Thanks for the comments. I have addressed the comments and adjusted the
> tests.
> In the V6 patch, Only insert_exists and delete_missing are tested.
>
> I confirmed that it only increased the testing time by 1 second on my machine.

Sorry, I sent the wrong patch in last email, please refer to the correct patch here.

Best Regards,
Hou zj