| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | RE: Synchronizing slots from primary to standby |
| Date: | 2023-11-13 00:49:28 |
| Message-ID: | OS0PR01MB571652CCD42F1D08D5BD69D494B3A@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, November 9, 2023 6:54 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
>
> PFA v32 patches which has below changes:
Thanks for updating the patch.
Here are few comments:
1.
Do we need to update the slot upgrade code in pg_upgrade to upgrade the slot's failover
property as well ?
2.
The check for wal_level < WAL_LEVEL_LOGICAL.
It seems the existing codes disallow slot creation if wal_level is not
sufficient, I am thinking we might need similar check in slot sync worker.
Otherwise, the synced slot could not be used after standby promotion.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | yuansong | 2023-11-13 02:30:44 | How to solve the problem of one backend process crashing and causing other processes to restart? |
| Previous Message | Tom Lane | 2023-11-13 00:11:48 | Re: Cleaning up array_in() |