Fix redundant comments in fmgr.c

From: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
To: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Fix redundant comments in fmgr.c
Date: 2021-04-22 11:44:10
Message-ID: OS0PR01MB5716405E2464D85E6DB6DC0794469@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I found some possible redundant comments in fmgr.c

1.
fmgr_symbol(Oid functionId, char **mod, char **fn)
{
HeapTuple procedureTuple;
Form_pg_proc procedureStruct;
bool isnull;
Datum prosrcattr;
Datum probinattr;
- /* Otherwise we need the pg_proc entry */
procedureTuple = SearchSysCache1(PROCOID, ObjectIdGetDatum(functionId));

I guess the comment here was miscopied from fmgr_info_cxt_security:

2.
if (!HeapTupleIsValid(procedureTuple))
elog(ERROR, "cache lookup failed for function %u", functionId);
procedureStruct = (Form_pg_proc) GETSTRUCT(procedureTuple);
- /*
- */

Best regards,
houzj

Attachment Content-Type Size
0001-fix-comment-in-fmgr.c.patch application/octet-stream 1016 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2021-04-22 11:49:49 Docs for lock level of ALTER TABLE .. VALIDATE
Previous Message Bharath Rupireddy 2021-04-22 11:39:02 Re: TRUNCATE on foreign table