| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | RE: Added schema level support for publication. |
| Date: | 2021-09-06 01:26:36 |
| Message-ID: | OS0PR01MB57163D9F4FCEE15493738C4B94D29@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From Thur, Sep 2, 2021 7:42 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Thu, Sep 2, 2021 at 11:58 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
>
> Below are few comments on v23. If you have already addressed anything in v24,
> then ignore it.
>
> 1. The commit message says: A new system table "pg_publication_schema"
> has been added, to maintain the schemas that the user wants to publish
> through the publication.". The alternative name for this system table could be
> "pg_publication_namespace". The reason why this alternative comes to my
> mind is that the current system table to store schema information is named
> pg_namespace. So shouldn't we be consistent here?
> What do others think about this?
Since the new system table refer to pg_namespace, so, personally, I am +1 for
"pg_publication_namespace".
Best regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-09-06 01:26:54 | RE: Skipping logical replication transactions on subscriber side |
| Previous Message | houzj.fnst@fujitsu.com | 2021-09-06 01:26:18 | RE: Added schema level support for publication. |