| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: create subscription with (origin = none, copy_data = on) |
| Date: | 2025-02-20 11:02:45 |
| Message-ID: | OS0PR01MB5716226D4EF79416B247861D94C42@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, January 29, 2025 8:19 PM Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> I have addressed the comments. Here is an updated patch.
Thanks for updating the patch. The patches look mostly OK to me, I only have
one minor comments in 0002.
1.
+CREATE PUBLICATION pub_b_c_2 FOR TABLE tab_part2_1;
+));
+
+($result, $stdout, $stderr) = $node_C->psql(
+ 'postgres', "
+ CREATE SUBSCRIPTION sub_b_c CONNECTION '$node_B_connstr' PUBLICATION pub_b_c WITH (origin = none, copy_data = on);
+");
The naming style of new publications and subscriptions doesn't seem consistent
with existing ones in 030_origin.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Koval | 2025-02-20 11:13:53 | Assert when executing query on partitioned table |
| Previous Message | Tatsuo Ishii | 2025-02-20 11:01:13 | Re: Commitfest app release on Feb 17 with many improvements |