From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com> |
Subject: | RE: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
Date: | 2021-08-23 09:15:13 |
Message-ID: | OS0PR01MB57161CAC4DB70114A72E516F94C49@OS0PR01MB5716.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Aug 23, 2021 12:59 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sat, Aug 7, 2021 at 6:53 PM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > Personally, I also think it will be better to make the behavior consistent.
> > Attach the new version patch make both ADD and DROP behave the same as
> > SET PUBLICATION which refresh all the publications.
> >
>
> I think we can have tests in the separate test file (alter_sub_pub.pl) like you
> earlier had in one of the versions. Use some meaningful names for tables
> instead of temp1, temp2 as you had in the previous version.
> Otherwise, the code changes look good to me.
Thanks for the comment.
Attach new version patch which did the following changes.
* move the tests to a separate test file (024_alter_sub_pub.pl)
* adjust the document of copy_data option
* add tab-complete for copy_data option when ALTER DROP publication.
Best regards,
Hou zj
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Fix-Alter-Subscription-Add-Drop-Publication-refresh-.patch | application/octet-stream | 10.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | houzj.fnst@fujitsu.com | 2021-08-23 09:15:25 | RE: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION |
Previous Message | Muhammad Usama | 2021-08-23 08:44:48 | Re: pg_dump handling of ALTER DEFAULT PRIVILEGES IN SCHEMA |