RE: Memory leak in pg_logical_slot_{get,peek}_changes

From: "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Memory leak in pg_logical_slot_{get,peek}_changes
Date: 2024-12-27 08:13:53
Message-ID: OS0PR01MB57160B4CAF3BB995155705C8940E2@OS0PR01MB5716.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thursday, December 26, 2024 8:01 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Here is an updated version which includes registers to reset the memory
> context that is in-line with a recently committed patch at [1].

Thanks for updating patches ! They look good to me.

Just to confirm, would the other stuff (streamed_txns) that allocated under
CacheMemoryContext also leaks memory ? I think it's OK to change them
separately if it does but just would like to confirm if there is a risk.

> [1] -
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=cfd6cbc
> f9be078fbdf9587014231a5772039b386

Best Regards,
Hou zj

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2024-12-27 08:25:02 Re: In-placre persistance change of a relation
Previous Message Michael Paquier 2024-12-27 07:37:02 Re: An improvement of ProcessTwoPhaseBuffer logic