| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Jan Wieck <jan(at)wi3ck(dot)info>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Subject: | RE: Conflict detection and logging in logical replication |
| Date: | 2024-06-26 02:57:47 |
| Message-ID: | OS0PR01MB5716094C114589064B1B21E594D62@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Monday, June 24, 2024 8:35 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> On Mon, Jun 24, 2024 at 7:39 AM Zhijie Hou (Fujitsu)
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > When testing the patch, I noticed a bug that when reporting the
> > conflict after calling ExecInsertIndexTuples(), we might find the
> > tuple that we just inserted and report it.(we should only report
> > conflict if there are other conflict tuples which are not inserted by
> > us) Here is a new patch which fixed this and fixed a compile warning
> reported by CFbot.
> >
> Thank you for the patch!
> A review comment: The patch does not detect 'update_differ' conflicts when
> the Publisher has a non-partitioned table and the Subscriber has a partitioned
> version.
Thanks for reporting the issue !
Here is the new version patch set which fixed this issue. I also fixed
some typos and improved the doc in logical replication conflict based
on the comments from Shveta[1].
Best Regards,
Hou zj
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Collect-statistics-about-conflicts-in-logical-rep.patch | application/octet-stream | 19.1 KB |
| v3-0001-Detect-and-log-conflicts-in-logical-replication.patch | application/octet-stream | 93.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-06-26 03:45:40 | Re: Improve the connection failure error messages |
| Previous Message | Peter Smith | 2024-06-26 02:36:07 | Re: Pgoutput not capturing the generated columns |