From: | "Hiroshi Inoue" <Inoue(at)tpf(dot)co(dot)jp> |
---|---|
To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | RE: [HACKERS] freefuncs.c is never called from anywhere!? |
Date: | 2000-01-30 06:05:13 |
Message-ID: | NDBBIJLOILGIKBGDINDFIEIGCCAA.Inoue@tpf.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> -----Original Message-----
> From: owner-pgsql-hackers(at)postgreSQL(dot)org
> [mailto:owner-pgsql-hackers(at)postgreSQL(dot)org]On Behalf Of Tom Lane
>
> I was rather bemused to discover just now that the node-freeing
> functions in nodes/freefuncs.c are never called from anywhere;
> in fact, the module hasn't got a single exported entry point!
>
> (I expect that freeObject() is supposed to be an external entry
> point; perhaps it got demoted to a static during one of Bruce's
> periodic get-rid-of-unreferenced-global-symbols passes.)
>
> So much for all that tedious labor to maintain the freeXXX functions
> every time we update a node type ;-)
>
As far as I see,freeObject() has a fundamental problem.
Probably it couldn't free multiple references safely.
Regards.
Hiroshi Inoue
Inoue(at)tpf(dot)co(dot)jp
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2000-01-30 06:32:51 | Re: [HACKERS] freefuncs.c is never called from anywhere!? |
Previous Message | Tom Lane | 2000-01-30 04:18:38 | Re: ImmediateSharedRelationCacheInvalidate considered harmful |