RE: [BUG FIX] Uninitialized var fargtypes used.

From: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [BUG FIX] Uninitialized var fargtypes used.
Date: 2019-11-12 11:38:16
Message-ID: MN2PR18MB2927B84B221B242765330E39E3770@MN2PR18MB2927.namprd18.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
Sorry by error in the patch.

--- \dll\postgresql-12.0\a\backend\commands\event_trigger.c Mon Sep 30 17:06:55 2019
+++ event_trigger.c Tue Nov 12 08:34:30 2019
@@ -171,7 +171,7 @@
HeapTuple tuple;
Oid funcoid;
Oid funcrettype;
- Oid fargtypes[1]; /* dummy */
+ Oid fargtypes[1] = {InvalidOid}; /* dummy */
Oid evtowner = GetUserId();
ListCell *lc;
List *tags = NULL;

________________________________
De: Michael Paquier <michael(at)paquier(dot)xyz>
Enviado: terça-feira, 12 de novembro de 2019 03:31
Para: Ranier Vilela <ranier_gyn(at)hotmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Assunto: Re: [BUG FIX] Uninitialized var fargtypes used.

On Mon, Nov 11, 2019 at 06:28:47PM +0000, Ranier Vilela wrote:
> Can anyone check this bug fix?
>
> +++ event_trigger.c Mon Nov 11 13:52:35 2019
> @@ -171,7 +171,7 @@
> HeapTuple tuple;
> Oid funcoid;
> Oid funcrettype;
> - Oid fargtypes[1]; /* dummy */
> + Oid fargtypes[1] = {InvalidOid, InvalidOid}; /* dummy */
> Oid evtowner = GetUserId();

Yeah, it would be better to fix this initialization.
--
Michael

Attachment Content-Type Size
event_trigger.c.patch application/octet-stream 375 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2019-11-12 12:00:19 Re: [HACKERS] Block level parallel vacuum
Previous Message Arseny Sher 2019-11-12 11:35:10 Re: ERROR: subtransaction logged without previous top-level txn record