| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Sadhuprasad Patro <b(dot)sadhu(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber |
| Date: | 2021-10-18 04:10:34 |
| Message-ID: | MEYP282MB1669F58E90835C9BA9CBCF08B6BC9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 18 Oct 2021 at 11:59, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sun, Oct 17, 2021 at 11:41:35PM -0400, Tom Lane wrote:
>> Ah ... see postgres_fdw's set_transmission_modes(). I think we want
>> to copy that logic not invent some other way to do it.
>
> dblink.c has something similar as of applyRemoteGucs(), except that it
> does not do extra_float_digits. It would be nice to avoid more
> duplication for those things, at least on HEAD. On the top of my
> head, don't we have something similar for parallel workers when
> passing down GUCs from the leader?
Since it will be used in more than one places. IMO, we can implement it in core.
Any thoughts?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2021-10-18 04:13:37 | Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber |
| Previous Message | Japin Li | 2021-10-18 04:03:53 | Re: [Bug] Logical Replication failing if the DateStyle is different in Publisher & Subscriber |