From: | Japin Li <japinli(at)hotmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c |
Date: | 2023-06-14 03:33:06 |
Message-ID: | MEYP282MB1669EC0FED922F7A151673ACB65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, hackers
We use (GUC_UNIT_MEMORY | GUC_UNIT_TIME) instead of GUC_UNIT even though we
already define it in guc.h.
Maybe using GUC_UNIT is better? Here is a patch to fix it.
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index a9033b7a54..5308896c87 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2766,7 +2766,7 @@ convert_real_from_base_unit(double base_value, int base_unit,
const char *
get_config_unit_name(int flags)
{
- switch (flags & (GUC_UNIT_MEMORY | GUC_UNIT_TIME))
+ switch (flags & GUC_UNIT)
{
case 0:
return NULL; /* GUC has no units */
@@ -2802,7 +2802,7 @@ get_config_unit_name(int flags)
return "min";
default:
elog(ERROR, "unrecognized GUC units value: %d",
- flags & (GUC_UNIT_MEMORY | GUC_UNIT_TIME));
+ flags & GUC_UNIT);
return NULL;
}
}
--
Regrads,
Japin Li.
From | Date | Subject | |
---|---|---|---|
Next Message | Zhijie Hou (Fujitsu) | 2023-06-14 03:53:54 | RE: Non-superuser subscription owners |
Previous Message | Zhijie Hou (Fujitsu) | 2023-06-14 03:15:30 | RE: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639) |