Re: Doc about how to set max_wal_senders when setting minimal wal_level

From: Japin Li <japinli(at)hotmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc about how to set max_wal_senders when setting minimal wal_level
Date: 2022-03-03 04:10:38
Message-ID: MEYP282MB1669A29D903F5D2C555719D1B6049@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Thu, 03 Mar 2022 at 11:25, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> I would suggest a wording more like:
>
> "A precondition for using minimal WAL is to disable WAL archiving and
> streaming replication by setting max_wal_senders to 0, and archive_mode to
> off."
>
> While accurate, the phrase "you must set" just doesn't feel right to me. I
> also don't like how the proposed sentence (either one) is added separately
> as opposed to being included in the immediately preceding paragraph. While
> this limited patch is probably sufficient I would suggest trying to work
> out a slightly larger patch the improves the wording on the entire existing
> paragraph while incorporating the reference to max_wal_senders.
>

Thanks for your review. Modified as your suggestion.

> Note, we seem to be missing the documentation of the default setting for
> archive_mode.
>

Add the default value for archive_mode.

> In addition, max_wal_senders could also be changed, adding a sentence like:
>
> "If setting max_wal_senders to 0 consider also reducing the amount of WAL
> produced by changing wal_level to minimal."
>

Modified.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

Attachment Content-Type Size
v2-wal-level-documentation.patch text/x-patch 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-03-03 05:03:38 Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set
Previous Message Peter Smith 2022-03-03 04:10:36 Re: PG DOCS - logical replication filtering