Re: Fix ALTER SUBSCRIPTION ... SET PUBLICATION documentation

From: japin <japinli(at)hotmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix ALTER SUBSCRIPTION ... SET PUBLICATION documentation
Date: 2021-01-27 13:21:24
Message-ID: MEYP282MB1669895C05325DCAA5E352D8B6BB0@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On Wed, 27 Jan 2021 at 19:47, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Wed, Jan 27, 2021 at 4:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> On Tue, Jan 26, 2021 at 4:56 PM japin <japinli(at)hotmail(dot)com> wrote:
>> >
>> >
>> > Hi,
>> >
>> > When I read the documentation of ALTER SUBSCRIPTION ... SET PUBLICATION ... WITH (...),
>> > it says "set_publication_option" only support "refresh" in documentation [1].
>> > However, we can also supply the "copy_data" option, and the code is:
>> >
>>
>> I think there is a reference to the 'copy_data' option as well. There
>> is a sentence saying: "Additionally, refresh options as described
>> under REFRESH PUBLICATION may be specified." and then if you Refresh
>> option, there we do mention about 'copy_data', isn't that sufficient?
>
> Right. It looks like the copy_option is indirectly mentioned with the
> statement "Additionally, refresh options as described under REFRESH
> PUBLICATION may be specified." under "set_publication_option". IMHO,
> we can keep it that way.
>

My bad. It may be sufficient. Sorry for noise.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-01-27 13:35:16 Re: Printing backtrace of postgres processes
Previous Message Amit Langote 2021-01-27 13:02:35 Re: simplifying foreign key/RI checks