| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Replace (GUC_UNIT_MEMORY | GUC_UNIT_TIME) with GUC_UNIT in guc.c |
| Date: | 2023-06-14 13:42:37 |
| Message-ID: | MEYP282MB166980680AB1C25961134677B65AA@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Jun 2023 at 17:52, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Wed, Jun 14, 2023 at 3:47 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
>> On Wed, Jun 14, 2023 at 03:38:10PM +0800, Richard Guo wrote:
>> > +1. BTW, it seems that GUC_UNIT_TIME is not used anywhere except in
>> > GUC_UNIT. I was wondering if we can retire it, but maybe we'd better
>> > not. It still indicates that we need to use time units table.
>>
>> Some out-of-core code declaring custom GUCs could rely on that, so
>> it is better not to remove it.
>
>
> I see. Thanks for pointing that out.
>
Thanks for all of your reviews. Agreed with Michael do not touch GUC_UNIT_TIME.
--
Regrads,
Japin Li.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-06-14 14:38:19 | Re: Do we want a hashset type? |
| Previous Message | Zhijie Hou (Fujitsu) | 2023-06-14 13:39:11 | RE: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639) |