Re: Typo in pg_db_role_setting.h

On Mon, 01 Aug 2022 at 20:46, John Naylor <john(dot)naylor(at)enterprisedb(dot)com> wrote:
> On Mon, Aug 1, 2022 at 4:18 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>>
>>
>> Hi, hackers
>>
>> I think there is a typo in pg_db_role_setting.h, should we fix it?
>>
>> diff --git a/src/include/catalog/pg_db_role_setting.h
> b/src/include/catalog/pg_db_role_setting.h
>> index 45d478e9e7..f92e867df4 100644
>> /*
>> - * prototypes for functions in pg_db_role_setting.h
>> + * prototypes for functions in pg_db_role_setting.c
>> */
>
> You are correct, but I wonder if it'd be better to just drop the comment
> entirely. I checked a couple other random headers with function
> declarations and they didn't have such a comment, and it's kind of obvious
> what they're for.

Both are fine for me. I find there are some headers also have such a comment,
like pg_enum, pg_range and pg_namespace.

--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.