| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Identify missing publications from publisher while create/alter subscription. |
| Date: | 2021-05-07 06:02:53 |
| Message-ID: | MEYP282MB166933BF96F1D58EBE4A5AB6B6579@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 06 May 2021 at 21:52, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> On Thu, May 6, 2021 at 9:08 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
>> 3) Should we free the memory when finish the check_publications()?
>> + publicationsCopy = list_copy(publications);
>
> I felt this list entries will be deleted in the success case, in error
> case I felt no need to delete it as we will be exiting. Thoughts?
>
Sorry for the noise! You are right. The v9 patch set looks good to me.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-05-07 06:20:23 | Re: Identify missing publications from publisher while create/alter subscription. |
| Previous Message | Dilip Kumar | 2021-05-07 05:34:53 | Re: Race condition in recovery? |