| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Tab complete for CREATE SUBSCRIPTION ... CONECTION does not work |
| Date: | 2023-12-27 06:31:31 |
| Message-ID: | ME3P282MB3166AD0CB975CF97E09C19DBB69FA@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 26 Dec 2023 at 18:10, Shubham Khanna <khannashubham1197(at)gmail(dot)com> wrote:
> On Tue, Dec 26, 2023 at 3:02 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>>
>>
>> Hi hacker,
>>
>> As $subject detailed, the tab-complete cannot work such as:
>>
>> CREATE SUBSCRIPTION sub CONNECTION 'dbname=postgres port=6543' \t
>>
>> It seems that the get_previous_words() could not parse the single quote.
>>
>> OTOH, it works for CREATE SUBSCRIPTION sub CONNECTION xx \t, should we fix it?
>>
> I reviewed the Patch and it looks fine to me.
>
Thanks for the review.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-12-27 06:34:50 | Re: A typo in a messsage? |
| Previous Message | Masahiko Sawada | 2023-12-27 06:06:13 | Re: Synchronizing slots from primary to standby |