| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>, wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: Support "Right Semi Join" plan shapes |
| Date: | 2024-07-04 15:18:23 |
| Message-ID: | ME3P282MB31669EF43BEC2D786B510FC5B6DE2@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 04 Jul 2024 at 17:17, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Fri, Jun 28, 2024 at 3:21 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>> On Fri, Jun 28, 2024 at 2:54 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>> > I've refined this test case further to make it more stable by using an
>> > additional filter 'a.tenthous < 5000'. Besides, I noticed a surplus
>> > blank line in ExecHashJoinImpl(). I've removed it in the v7 patch.
>>
>> BTW, I've also verified the empty-rel optimization for hash join and
>> AFAICT it works correctly for the new right-semi join.
>
> Here is a new rebase.
>
> Barring objections, I'm planning to push it soon.
>
Thanks for updating the patch. It looks good to me, except for a minor nitpick:
s/right-semijoin/right-semi join/
--
Regrads,
Japin Li
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2024-07-04 15:19:22 | Re: Problem while installing PostgreSQL using make |
| Previous Message | David E. Wheeler | 2024-07-04 14:45:27 | Re: Document DateStyle effect on jsonpath string() |