| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption |
| Date: | 2024-05-23 14:30:18 |
| Message-ID: | ME3P282MB316673BAB0531593C736DAF1B6F42@ME3P282MB3166.AUSP282.PROD.OUTLOOK.COM |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 23 May 2024 at 14:54, Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
> Hi Japin,
>
> Thanks, the patch looks good to me.
>
> However, as a non-native English speaker, it might not be accurate.
>> Feel free to modify it.
>>
>>
> I'm also not good at wording, but I have a minor suggestions like the
> following :
>
> /*
> * Also, the FETCH FIRST/NEXT ... ROW/ROWS WITH TIES clause cannot be
> pushed down
> * because:
> * a) The remote system may have a different understanding of equality,
> which can
> * result in varying results, such as non-deterministic collations.
> * b) We do not have knowledge of the remote server's version
> * as this clause is only supported for PG13 and above.
> */
>
Thanks for your review! Fixed in v5 patch.
--
Regards,
Japin Li
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Disable-push-down-FETCH-FIRST-WITH-TIES-clause.patch | text/x-diff | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2024-05-23 14:31:52 | Re: Bug report - pg_upgrade tool seems to have a race condition when trying to delete a pg_wal file |
| Previous Message | Robert Haas | 2024-05-23 13:52:22 | Re: BUG #18362: unaccent rules and Old Greek text |