From: | Japin Li <japinli(at)hotmail(dot)com> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Incorrect translator comment for ListenServerPort()? |
Date: | 2025-02-17 14:39:22 |
Message-ID: | ME0P300MB04458DE627480614ABE639D2B6FB2@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, all
When I read the ListenServerPort(), I noticed two incorrect translator
implementations: 1) the translator for setsockopt(SO_REUSEADDR), which
should not be "Unix"; 2) the translator for setsockopt(IPV6_V6ONLY),
which is applicable only to IPv6.
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index 1bf27d93cfa..9f58e4c4e39 100644
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -571,7 +571,7 @@ ListenServerPort(int family, const char *hostName, unsigned short portNumber,
{
ereport(LOG,
(errcode_for_socket_access(),
- /* translator: third %s is IPv4, IPv6, or Unix */
+ /* translator: third %s is IPv4 or IPv6 */
errmsg("%s(%s) failed for %s address \"%s\": %m",
"setsockopt", "SO_REUSEADDR",
familyDesc, addrDesc)));
@@ -589,7 +589,7 @@ ListenServerPort(int family, const char *hostName, unsigned short portNumber,
{
ereport(LOG,
(errcode_for_socket_access(),
- /* translator: third %s is IPv4, IPv6, or Unix */
+ /* translator: third %s is IPv6 */
errmsg("%s(%s) failed for %s address \"%s\": %m",
"setsockopt", "IPV6_V6ONLY",
familyDesc, addrDesc)));
--
Regrads,
Japin Li
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2025-02-17 14:42:49 | Re: Restrict publishing of partitioned table with a foreign table as partition |
Previous Message | Robert Haas | 2025-02-17 14:19:43 | Re: explain analyze rows=%.0f |