Re: Incorrect translator comment for ListenServerPort()?

From: Japin Li <japinli(at)hotmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect translator comment for ListenServerPort()?
Date: 2025-02-17 14:58:52
Message-ID: ME0P300MB04453160F35F8A0E770B1E65B6FB2@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 17 Feb 2025 at 15:45, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>> On 17 Feb 2025, at 15:39, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>> When I read the ListenServerPort(), I noticed two incorrect translator
>> implementations: 1) the translator for setsockopt(SO_REUSEADDR), which
>> should not be "Unix"; 2) the translator for setsockopt(IPV6_V6ONLY),
>> which is applicable only to IPv6.
>
> Nice catches, I agree with your conclusions. I'll apply these in a bit.
>

Thanks for your quick review.

--
Regrads,
Japin Li

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2025-02-17 15:14:59 Re: per backend WAL statistics
Previous Message Tomas Vondra 2025-02-17 14:56:51 Re: Parallel CREATE INDEX for GIN indexes