Re: test_escape: invalid option -- 'c'

From: Japin Li <japinli(at)hotmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: test_escape: invalid option -- 'c'
Date: 2025-02-19 02:31:40
Message-ID: ME0P300MB04452BD1FB1B277D4C1C20B9B6C52@ME0P300MB0445.AUSP300.PROD.OUTLOOK.COM
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 19 Feb 2025 at 09:53, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Feb 18, 2025 at 12:46:50PM +0900, Michael Paquier wrote:
>> You are right, obviously. The only reason why this is not showing up
>> is that the TAP test uses the long option --conninfo. Speaking of
>> which, this had better use fat commas to combine the option/value
>> pairs in these commands.
>
> This was also missing 'f', which is listed as an option. I've
> reordered all these to be alphabetical in the list, and applied the
> result down to v13. Thanks for the report.

Thanks.

I didn't add the 'f' option since the usage() does not declare it.
If you add this, we also should update the usage(), right?

diff --git a/src/test/modules/test_escape/test_escape.c b/src/test/modules/test_escape/test_escape.c
index a8e9c3cb518..f6b36448977 100644
--- a/src/test/modules/test_escape/test_escape.c
+++ b/src/test/modules/test_escape/test_escape.c
@@ -801,7 +801,7 @@ usage(const char *hint)
" -c, --conninfo=CONNINFO connection information to use\n"
" -v, --verbose show test details even for successes\n"
" -q, --quiet only show failures\n"
- " --force-unsupported test invalid input even if unsupported\n"
+ " -f, --force-unsupported test invalid input even if unsupported\n"
);

if (hint)

--
Regrads,
Japin Li

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-02-19 02:35:56 Re: GetRelationPath() vs critical sections
Previous Message Tom Lane 2025-02-19 02:30:45 Re: Why does exec_simple_query requires 2 snapshots