From: | "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Wrong example in the bloom documentation |
Date: | 2020-10-17 13:50:26 |
Message-ID: | GVAP278MB01022477E6F7AE58E207CF25D2000@GVAP278MB0102.CHEP278.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-docs pgsql-hackers |
On Fri, Oct 9, 2020 at 11:08:32AM -0400, Bruce Momjian wrote:
> On Fri, Oct 9, 2020 at 05:44:57AM +0000, Daniel Westermann (DWE) wrote:
> > Hi Bruce, Tom,
> >
> > On Thu, Oct 8, 2020 at 03:43:32PM -0400, Tom Lane wrote:
> > >> "Daniel Westermann (DWE)" <daniel(dot)westermann(at)dbi-services(dot)com> writes:
> > >> >> I was hoping someone more experienced with this would comment, but
> > >> >> seeing none, I will apply it in a day or two to all supported versions?
> > >> >> Have you tested this output back to 9.5?
> > >>
> > >> > I hoped that as well. No, I tested down to 9.6 because the change happened in 10.
> > >>
> > >> The patch assumes that parallel query is enabled, which is not true by
> > >> default before v10, so it should certainly not be applied before v10
> > >> (at least not without significant revisions).
> >>
> >> Yes, the behavior change was in 10. Before 10 the example is fine, I would not apply that to any prior version, otherwise the whole example needs to be rewritten.
>>
>> Agreed.
>This is not applying to PG 12 or earlier because the patch mentions JIT,
>which was only mentioned in the PG bloom docs in PG 13+.
Does that mean we need separate patches for each release starting with 10?
As I am not frequently writing patches, I would need some help here.
Regards
Daniel
From | Date | Subject | |
---|---|---|---|
Next Message | PG Doc comments form | 2020-10-18 20:13:40 | https://www.postgresql.org/docs/13/tutorial-join.html missing a table |
Previous Message | Kasper Kondzielski | 2020-10-17 12:51:47 | Re: Request for further clarification on synchronous_commit |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2020-10-17 13:54:46 | Re: Sometimes the output to the stdout in Windows disappears |
Previous Message | Ian Lawrence Barwick | 2020-10-17 13:04:38 | [doc] improve tableoid description |