Re: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs

Thanks Tom!

True it is that is perfectly valid English. However, that interpretation might not result trivial to us non-native English speakers.

Would be great if at some point it could be changed to make it clearer.

BTW, it also appears in the definition of the pg_stats_ext_exprs system view.

Regards,
Nacho

________________________________
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Sent: Wednesday, March 13, 2024 3:37 PM
To: Nacho Alonso Portillo <Ignacio(dot)Alonso(at)microsoft(dot)com>
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: [EXTERNAL] Re: Incomplete sentence in the description for most_common_freqs

[You don't often get email from tgl(at)sss(dot)pgh(dot)pa(dot)us(dot) Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

PG Doc comments form <noreply(at)postgresql(dot)org> writes:
> It seems the ending clarifying sentence:
> "(Null when most_common_vals is.)"
> should rather be:
> "(Null when most_common_vals is null.)"

I think it's perfectly good English as-is, if a bit terse.

regards, tom lane