Re: pgsql-server/contrib/dblink Makefile

I've noticed this as well - someones's screwed the tests I think...

Hmmm - there's all sorts of problems in contrib:

chriskl(at)alpha:~/pgsql-head/contrib/tsearch$ make clean
"../../src/Makefile.global", line 38: Missing dependency operator
"../../src/Makefile.global", line 41: Need an operator
"../../src/Makefile.global", line 45: Need an operator
"../../src/Makefile.global", line 66: Need an operator
"../../src/Makefile.global", line 67: Need an operator
"../../src/Makefile.global", line 69: Need an operator
"../../src/Makefile.global", line 70: Need an operator
"../../src/Makefile.global", line 73: Need an operator
"../../src/Makefile.global", line 74: Need an operator
"../../src/Makefile.global", line 76: Need an operator
"../../src/Makefile.global", line 77: Need an operator
"../../src/Makefile.global", line 80: Need an operator
"../../src/Makefile.global", line 81: Need an operator
"../../src/Makefile.global", line 83: Need an operator
"../../src/Makefile.global", line 84: Need an operator
"../../src/Makefile.global", line 88: Need an operator
"../../src/Makefile.global", line 89: Need an operator
"../../src/Makefile.global", line 91: Need an operator
"../../src/Makefile.global", line 92: Need an operator
"../../src/Makefile.global", line 96: Need an operator
"../../src/Makefile.global", line 97: Need an operator
"../../src/Makefile.global", line 99: Need an operator
"../../src/Makefile.global", line 100: Need an operator
"../../src/Makefile.global", line 108: Need an operator
"../../src/Makefile.global", line 109: Need an operator
"../../src/Makefile.global", line 111: Need an operator
"../../src/Makefile.global", line 112: Need an operator
"../../src/Makefile.global", line 170: Need an operator
"../../src/Makefile.global", line 172: Need an operator
"../../src/Makefile.global", line 177: Missing dependency operator
"../../src/Makefile.global", line 179: Need an operator
"../../src/Makefile.global", line 184: Missing dependency operator
"../../src/Makefile.global", line 186: Need an operator
"../../src/Makefile.port", line 3: Need an operator
"../../src/Makefile.port", line 7: Need an operator
"../../src/Makefile.port", line 13: Need an operator
"../../src/Makefile.port", line 15: Need an operator
"../../src/Makefile.port", line 23: Need an operator
"../../src/Makefile.global", line 288: Missing dependency operator
"../../src/Makefile.global", line 290: Need an operator
"../../src/Makefile.global", line 324: Need an operator
"../../src/Makefile.global", line 326: Missing dependency operator
"../../src/Makefile.global", line 328: Need an operator
"../../src/Makefile.global", line 330: Missing dependency operator
"../../src/Makefile.global", line 332: Need an operator
"../../src/Makefile.global", line 334: Missing dependency operator
"../../src/Makefile.global", line 336: Need an operator
"../../src/Makefile.global", line 338: Need an operator
"../../src/Makefile.global", line 341: Need an operator
"../../src/Makefile.global", line 343: Need an operator
"../../src/Makefile.global", line 346: Need an operator
"../../src/Makefile.global", line 355: Missing dependency operator
"../../src/Makefile.global", line 358: Need an operator
"../../src/Makefile.global", line 434: Missing dependency operator
"../../src/Makefile.global", line 436: Need an operator
"../../src/Makefile.global", line 438: Need an operator
"../../src/Makefile.global", line 440: Need an operator
"../../src/Makefile.global", line 442: Need an operator
"../../src/Makefile.global", line 449: Need an operator
"../../src/Makefile.global", line 452: Need an operator
"../../src/Makefile.global", line 453: Need an operator
"../../src/Makefile.global", line 455: Need an operator
"../../src/Makefile.global", line 456: Need an operator
"../../src/Makefile.global", line 458: Missing dependency operator
"../../src/Makefile.global", line 465: Need an operator
"../../src/Makefile.global", line 467: Missing dependency operator
"../../src/Makefile.global", line 473: Need an operator
"../../src/Makefile.global", line 478: Need an operator
"../../src/Makefile.global", line 487: Need an operator
"../../src/Makefile.global", line 494: Missing dependency operator
"../../src/Makefile.global", line 495: Missing dependency operator
"/home/chriskl/pgsql-head/src/nls-global.mk", line 25: Could not find
/home/chriskl/pgsql-head/contrib/tsearch/nls.mk
"/home/chriskl/pgsql-head/src/nls-global.mk", line 29: Need an operator
"/home/chriskl/pgsql-head/src/nls-global.mk", line 31: Need an operator
"/home/chriskl/pgsql-head/src/nls-global.mk", line 33: Need an operator
"/home/chriskl/pgsql-head/src/nls-global.mk", line 38: Need an operator
"/home/chriskl/pgsql-head/src/nls-global.mk", line 40: Need an operator
Error expanding embedded variable.

Chris

> -----Original Message-----
> From: Joe Conway [mailto:mail(at)joeconway(dot)com]
> Sent: Wednesday, 4 September 2002 2:43 AM
> To: Christopher Kings-Lynne
> Cc: Tom Lane; pgsql-committers(at)postgresql(dot)org
> Subject: Re: [COMMITTERS] pgsql-server/contrib/dblink Makefile
>
>
> Christopher Kings-Lynne wrote:
> >>I see what you did, and understand why, but it made me wonder if there
> >>is a more standard way of doing a test procedure for contrib. Should I
> >>be doing something differently?
> >
> > Yep - check contrib/tsearch
> >
>
> I did:
>
> cd contrib/tsearch
> make
> make install
> make installcheck
>
> I get very odd results:
>
> [...]
> + count_ignored=0
> + echo
>
> + '[' 1 -eq 1 ']'
> + msg=All 1 tests passed.
> + result=0
> ++ echo ' All 1 tests passed. '
> ++ sed s/./=/g
> + dashes======================
> + echo =====================
> =====================
> + echo ' All 1 tests passed. '
> All 1 tests passed.
> + echo =====================
> =====================
> + echo
>
> + '[' -s ./regression.diffs ']'
> + rm -f ./regression.diffs ./regression.out
> + exit 0
> + exit
> + savestatus=0
> + '[' -n '' ']'
> + rm -f /tmp/pg_regress.4294
> + exit 0
>
> I take it that means that the test passed, but am I doing something
> wrong to get these results?
>
> Joe
>
>