Re: Unescaped new lines in postgres

From: "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>
To: "Bruce Momjian" <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: "Hackers" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Unescaped new lines in postgres
Date: 2001-11-23 04:53:55
Message-ID: GNELIHDDFBOCMGBFGEFOMEIKCAAA.chriskl@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>From heap.c:

/*
* sanity checks
*/
if (relname && !allow_system_table_mods &&
IsSystemRelationName(relname) && IsNormalProcessingMode())
elog(ERROR, "invalid relation name \"%s\"; "
"the 'pg_' name prefix is reserved for system
catalogs",
relname);

I guess this is a slightly different example than what the issue is below.
Maybe I'm wrong and the above code is still legal. Even so, seems a bit
dodgy to me...

Chris

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman(at)candle(dot)pha(dot)pa(dot)us]
> Sent: Friday, 23 November 2001 12:26 PM
> To: Christopher Kings-Lynne
> Cc: Hackers
> Subject: Re: [HACKERS] Unescaped new lines in postgres
>
>
>
> Can you show an example?
>
> ------------------------------------------------------------------
> ---------
>
> > >From the gcc 3.0.2 release ntoes:
> >
> > "The poorly documented extension that allowed string constants
> in C, C++ and
> > Objective C to contain unescaped newlines has been deprecated and may be
> > removed in a future version. Programs using this extension may
> be fixed in
> > several ways: the bare newline may be replaced by \n, or
> preceded by \n\, or
> > string concatenation may be used with the bare newline preceded
> by \n" and "
> > placed at the start of the next line. "
> >
> > I seem to recall that I came across a fair bit of this kind of
> thing in the
> > psql source code at least. I wonder if it should be fixed to be
> > compliant...
> >
> > Chris
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: you can get off all lists at once with the unregister command
> > (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> >
>
> --
> Bruce Momjian | http://candle.pha.pa.us
> pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
> + If your life is a hard drive, | 830 Blythe Avenue
> + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-11-23 04:55:15 Re: Unescaped new lines in postgres
Previous Message Tom Lane 2001-11-23 04:42:46 Re: Unescaped new lines in postgres