Re: CLUSTER patch and regression test

From: "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>
To: "Neil Conway" <nconway(at)klamath(dot)dyndns(dot)org>, "Alvaro Herrera" <alvherre(at)atentus(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: CLUSTER patch and regression test
Date: 2002-08-08 02:29:38
Message-ID: GNELIHDDFBOCMGBFGEFOCEJFCDAA.chriskl@familyhealth.com.au
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Yeah - Alvaro needs to sync with Tom's catalog index improvements - he
should be able to see example code in tablecmds.c, or in the orginal version
of the file this error is in?

Chris

> Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> > I sent the CLUSTER patch a few days ago and I think it was missed. I
> > append it again, this time including the regression test files.
>
> Applying the patch to current CVS and compiling produces:
>
> gcc -g3 -O0 -DPS_USE_NONE -Wall -Wmissing-prototypes
> -Wmissing-declarations -I../../../src/include -c -o cluster.o
> cluster.c -MMD
> cluster.c: In function `swap_relfilenodes':
> cluster.c:383: `Num_pg_class_indices' undeclared (first use in
> this function)
> cluster.c:383: (Each undeclared identifier is reported only once
> cluster.c:383: for each function it appears in.)
> cluster.c:432: warning: implicit declaration of function
> `CatalogOpenIndices'
> cluster.c:432: `Name_pg_class_indices' undeclared (first use in
> this function)
> cluster.c:433: too many arguments to function `CatalogIndexInsert'
> cluster.c:434: too many arguments to function `CatalogIndexInsert'
> cluster.c:435: warning: implicit declaration of function
> `CatalogCloseIndices'
> cluster.c:383: warning: unused variable `irels'
> make[3]: *** [cluster.o] Error 1
> make[3]: Leaving directory `/home/nconway/pgsql/src/backend/commands'
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2002-08-08 02:39:48 Re: improve SET CONSTRAINTS
Previous Message Tom Lane 2002-08-08 02:23:10 Re: improve SET CONSTRAINTS