| From: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fd.c: flush data problems on osx |
| Date: | 2016-03-21 12:09:56 |
| Message-ID: | FF9F0CF0-B2C9-46B4-8338-4A1593A55146@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21 Mar 2016, at 14:53, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hm. I think we should rather just skip calling pg_flush_data in the
> directory case, that very likely isn't beneficial on any OS.
Seems reasonable, changed.
> I think we still need to fix the mmap() implementation to support the
> offset = 0, nbytes = 0 case (via fseek(SEEK_END).
It is already in this diff. I’ve added this few messages ago.
| Attachment | Content-Type | Size |
|---|---|---|
| flushdata.v4.patch | application/octet-stream | 1.2 KB |
| unknown_filename | text/plain | 94 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-03-21 12:10:07 | Re: Relation extension scalability |
| Previous Message | Alexander Korotkov | 2016-03-21 12:01:56 | Re: [PATCH] Phrase search ported to 9.6 |