Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data
Date: 2021-08-23 17:38:00
Message-ID: FF50049D-AA61-4C86-9339-841102E7CE97@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

> 22 авг. 2021 г., в 22:42, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> написал(а):
>
>
> Currently when testing combination of all fixes I observe things like
> 'error running SQL: 'psql:<stdin>:1: ERROR: prepared transaction with identifier "a" is busy''
> Looks like kind of race condition in tests.

There was a race condition in deterministic 2PC test. Fixed with synchronisation points.
PFA patches that work on my machines.
I'm going to start fixing review notes if it will not break until tomorrow.

BTW are subtransaction anything special wrt CIC? is it worth to sprinkle some SAVEPOINTs here and there, just to be sure?

Thanks!

Best regards, Andrey Borodin.

Attachment Content-Type Size
v12-0001-Introduce-TAP-test-for-CIC.patch application/octet-stream 5.4 KB
v12-0002-PoC-fix-for-race-in-RelationBuildDesc-and-relcac.patch application/octet-stream 2.2 KB
v12-0003-Introduce-TAP-test-for-2PC-with-CIC-behavior.patch application/octet-stream 4.4 KB
v12-0004-Fix-CREATE-INDEX-CONCURRENTLY-in-precence-of-vxi.patch application/octet-stream 7.7 KB
v12-0005-PoC-fix-clear-xid.patch application/octet-stream 1.8 KB
v12-0006-Do-CIC-test-time-based-to-ensure-bug-repro.patch application/octet-stream 1.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Masahiko Sawada 2021-08-24 05:06:33 Re: pg_basebackup behavior on non-existent slot
Previous Message Gerard H. Pille 2021-08-23 14:51:53 Re: pg_basebackup behavior on non-existent slot