| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Date: | 2024-04-24 09:19:59 |
| Message-ID: | FC257A2E-D989-46DC-8232-AB14C3D7A0B2@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 24 Apr 2024, at 11:13, Anton A. Melnikov <a(dot)melnikov(at)postgrespro(dot)ru> wrote:
>
> On 24.04.2024 12:02, Peter Eisentraut wrote:
>> On 19.04.24 05:50, Anton A. Melnikov wrote:
>>>
>>> May be better use this macro everywhere in C code?
>> I don't know. I don't find XLOG_CONTROL_FILE to be a very intuitive proxy for "pg_control".
Maybe, but inconsistent usage is also unintuitive.
> Then maybe replace XLOG_CONTROL_FILE with PG_CONTROL_FILE?
>
> The PG_CONTROL_FILE_SIZE macro is already in the code.
> With the best regards,
XLOG_CONTROL_FILE is close to two decades old so there might be extensions
using it (though the risk might be slim), perhaps using offering it as as well
as backwards-compatability is warranted should we introduce a new name?
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anton A. Melnikov | 2024-04-24 09:32:46 | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Previous Message | Anthonin Bonnefoy | 2024-04-24 09:19:26 | Re: Fix parallel vacuum buffer usage reporting |