Re: Amcheck verification of GiST and GIN

From: "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>
To: Alexander Lakhin <exclusion(at)gmail(dot)com>
Cc: Andrey Borodin <amborodin86(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Amcheck verification of GiST and GIN
Date: 2024-07-05 12:27:55
Message-ID: FB5F240A-4B03-4043-8EA7-C8AD79F5891B@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 6 Apr 2023, at 09:00, Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> I've tried to use this feature with the latest patch set and discovered that
> modified pg_amcheck doesn't find any gist indexes when running without a
> schema specification.

Thanks, Alexander! I’ve fixed this problem and rebased on current HEAD.
There’s one more problem in pg_amcheck’s GiST verification. We must check that amcheck is 1.5+ and use GiST verification only in that case…

Best regards, Andrey Borodin.

Attachment Content-Type Size
v27-0001-Refactor-amcheck-to-extract-common-locking-routi.patch application/octet-stream 19.9 KB
v27-0004-Add-GiST-support-to-pg_amcheck.patch application/octet-stream 30.7 KB
v27-0003-Add-gin_index_parent_check-to-verify-GIN-index.patch application/octet-stream 32.3 KB
v27-0002-Add-gist_index_check-function-to-verify-GiST-ind.patch application/octet-stream 33.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2024-07-05 12:35:32 Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions
Previous Message vignesh C 2024-07-05 12:05:34 Re: Logical Replication of sequences