From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Kurt Harriman <harriman(at)acm(dot)org>, pgsql-hackers(at)postgresql(dot)org, Brendan Jurd <direvus(at)gmail(dot)com> |
Subject: | Re: pg_typeof() patch review |
Date: | 2008-11-03 18:44:54 |
Message-ID: | FA34FA47-D2F6-4DD0-BCF2-D274C456B8A9@kineticode.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Nov 3, 2008, at 10:02 AM, Tom Lane wrote:
> "David E. Wheeler" <david(at)kineticode(dot)com> writes:
>> On Nov 3, 2008, at 1:28 AM, Kurt Harriman wrote:
>>> 2) func.sgml: clarifying that the function returns an OID rather
>>> than a string
>
>> Actually, it returns a regtype, no?
>
> I thought the description was good, because it emphasizes that the
> result is-a OID; the table entry says "regtype" but people might not
> realize that that means they can use it as, eg, something to compare
> to pg_attribute.atttypid.
Well, as someone who was until recently unfamiliar with regtypes, and
who thinks of an OID as essentially just a number, I would find it
very useful if the description indicated that, as a regtype, the
return value could be used as either an OID or as string. Otherwise,
I'd find the description kind of confusing (in one place it says it
returns a regtype, "whatever *that* is", and in one place it says an
OID).
Just thinking at this from the point of view of a relative newbiew…
Thanks,
David
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2008-11-03 18:52:35 | Re: pg_typeof() patch review |
Previous Message | Tom Lane | 2008-11-03 18:02:48 | Re: pg_typeof() patch review |