Re: [PATCH] New SSL Socket Factory With Certificate Validation

On Aug 28, 2013, at 7:43 AM, Sehrope Sarkuni <sehrope(at)jackdb(dot)com> wrote:

> Hi-
>
> I tried posting this a couple weeks ago but it kept getting rejected
> by the list's filter so I ended up putting all the info in a pull
> request on GitHub (https://github.com/pgjdbc/pgjdbc/pull/80) Looks
> like I can (finally) post here now so here goes …

Hi,

This looks like really cool functionality. My main concern with the code as written is that testing it requires manual steps, including booting a virtual machine and running a separate build.

In my experience, any steps beyond the simple "run all the tests" step will never be done. Human nature.

Would it be possible to convert the test case to run as a part of the normal test suite?

There are also a couple of scary places where exceptions are swallowed, e.g. SingleCertTrustManager#<init>

Best,
Steven