From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Some deleted GUCs are still referred to |
Date: | 2023-11-09 09:12:03 |
Message-ID: | F98636D2-B4C4-4CE8-8EA6-E29CFA544CB4@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-translators |
> On 9 Nov 2023, at 00:51, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi,
>
> I happened to notice that some GUC names "max_fsm_pages" and
> "max_fsm_relations" are still mentioned in these translation files
> (from the REL_16_1 source zip)
>
> src\backend\po\fr.po
> src\backend\po\tr.po
>
> ~~
>
> Should those be removed?
These mentions are only in comments and not in actual translations, so I don't
think they risk causing any issues.
$ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l
0
I don't know enough about the translation workflow to know how these comments
are handled, sending this to pgsql-translators@ might be a better way to reach
the authors working on this.
> There was a commit [1] that said these all traces of those GUCs had
> been eliminated.
Translations are managed in an external repo and synced with the main repo at
intervals, so such a commit couldn't have updated the master translation work
files anyways.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Nazir Bilal Yavuz | 2023-11-09 09:35:46 | Re: Show WAL write and fsync stats in pg_stat_io |
Previous Message | Shlok Kyal | 2023-11-09 08:59:39 | Failure during Building Postgres in Windows with Meson |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Smith | 2023-11-13 23:32:16 | Re: Some deleted GUCs are still referred to |
Previous Message | Peter Smith | 2023-11-08 23:51:06 | Some deleted GUCs are still referred to |