| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fast default stuff versus pg_upgrade |
| Date: | 2018-06-21 16:30:27 |
| Message-ID: | F827429E-5138-4A29-ADFC-3D61EAF96CDD@anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On June 21, 2018 9:04:28 AM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>> Patch after pgindent attached. This will involve a catversion bump
>since
>> we're adding a new function.
>
>This isn't really ready to go. One clear problem is that you broke
>pg_dump'ing from any pre-v11 version, because you did not add suitable
>null outputs to the pre-v11 query variants in getTableAttrs.
Thought the same for a bit - think it's OK though, because there a check for PQfnumber being bigger than 0...
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-06-21 16:39:17 | Re: Fast default stuff versus pg_upgrade |
| Previous Message | Tom Lane | 2018-06-21 16:08:49 | Re: Fast default stuff versus pg_upgrade |